Commit a4a4819
test: do not check text for engine-generated error
In test-tls-wrap-event-emitter, the text of a TypeError is checked as
part of the test. However, this text is generated by the JavaScript
engine (V8) and not Node.js. Thus, we should not check the text as JS
engine error messages can change without it being considered a breaking
change for Node.js.
A side effect is that node-chakracore will no longer need to patch this
test to pass.
PR-URL: #19215
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 9613e02 commit a4a4819
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -15,5 +15,5 @@ const TlsSocket = require('tls').TLSSocket; | |||
| 15 | 15 | const EventEmitter = require('events').EventEmitter; | |
| 16 | 16 | assert.throws( | |
| 17 | 17 | () => { new TlsSocket(new EventEmitter()); }, | |
| 18 | - /^TypeError: (.+) is not a function$/ | ||
| 18 | + TypeError | ||
| 19 | 19 | ); | |
0 commit comments