Commit a4d1436
test: fix args in parallel/test-fs-null-bytes.js
The functions `fs.appendFile()` and `fs.writeFile()`
were being called without the required `data` argument.
Refs: #11595
PR-URL: #11601
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>1 parent 8377374 commit a4d1436
1 file changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -23,7 +23,7 @@ function check(async, sync) { | |||
| 23 | 23 | ||
| 24 | 24 | check(fs.access, fs.accessSync, 'foo\u0000bar'); | |
| 25 | 25 | check(fs.access, fs.accessSync, 'foo\u0000bar', fs.F_OK); | |
| 26 | - check(fs.appendFile, fs.appendFileSync, 'foo\u0000bar'); | ||
| 26 | + check(fs.appendFile, fs.appendFileSync, 'foo\u0000bar', 'abc'); | ||
| 27 | 27 | check(fs.chmod, fs.chmodSync, 'foo\u0000bar', '0644'); | |
| 28 | 28 | check(fs.chown, fs.chownSync, 'foo\u0000bar', 12, 34); | |
| 29 | 29 | check(fs.link, fs.linkSync, 'foo\u0000bar', 'foobar'); | |
@@ -47,14 +47,14 @@ check(null, fs.unwatchFile, 'foo\u0000bar', common.mustNotCall()); | |||
| 47 | 47 | check(fs.utimes, fs.utimesSync, 'foo\u0000bar', 0, 0); | |
| 48 | 48 | check(null, fs.watch, 'foo\u0000bar', common.mustNotCall()); | |
| 49 | 49 | check(null, fs.watchFile, 'foo\u0000bar', common.mustNotCall()); | |
| 50 | - check(fs.writeFile, fs.writeFileSync, 'foo\u0000bar'); | ||
| 50 | + check(fs.writeFile, fs.writeFileSync, 'foo\u0000bar', 'abc'); | ||
| 51 | 51 | ||
| 52 | 52 | const fileUrl = new URL('file:///C:/foo\u0000bar'); | |
| 53 | 53 | const fileUrl2 = new URL('file:///C:/foo%00bar'); | |
| 54 | 54 | ||
| 55 | 55 | check(fs.access, fs.accessSync, fileUrl); | |
| 56 | 56 | check(fs.access, fs.accessSync, fileUrl, fs.F_OK); | |
| 57 | - check(fs.appendFile, fs.appendFileSync, fileUrl); | ||
| 57 | + check(fs.appendFile, fs.appendFileSync, fileUrl, 'abc'); | ||
| 58 | 58 | check(fs.chmod, fs.chmodSync, fileUrl, '0644'); | |
| 59 | 59 | check(fs.chown, fs.chownSync, fileUrl, 12, 34); | |
| 60 | 60 | check(fs.link, fs.linkSync, fileUrl, 'foobar'); | |
@@ -78,11 +78,11 @@ check(null, fs.unwatchFile, fileUrl, common.fail); | |||
| 78 | 78 | check(fs.utimes, fs.utimesSync, fileUrl, 0, 0); | |
| 79 | 79 | check(null, fs.watch, fileUrl, common.fail); | |
| 80 | 80 | check(null, fs.watchFile, fileUrl, common.fail); | |
| 81 | - check(fs.writeFile, fs.writeFileSync, fileUrl); | ||
| 81 | + check(fs.writeFile, fs.writeFileSync, fileUrl, 'abc'); | ||
| 82 | 82 | ||
| 83 | 83 | check(fs.access, fs.accessSync, fileUrl2); | |
| 84 | 84 | check(fs.access, fs.accessSync, fileUrl2, fs.F_OK); | |
| 85 | - check(fs.appendFile, fs.appendFileSync, fileUrl2); | ||
| 85 | + check(fs.appendFile, fs.appendFileSync, fileUrl2, 'abc'); | ||
| 86 | 86 | check(fs.chmod, fs.chmodSync, fileUrl2, '0644'); | |
| 87 | 87 | check(fs.chown, fs.chownSync, fileUrl2, 12, 34); | |
| 88 | 88 | check(fs.link, fs.linkSync, fileUrl2, 'foobar'); | |
@@ -106,7 +106,7 @@ check(null, fs.unwatchFile, fileUrl2, common.fail); | |||
| 106 | 106 | check(fs.utimes, fs.utimesSync, fileUrl2, 0, 0); | |
| 107 | 107 | check(null, fs.watch, fileUrl2, common.fail); | |
| 108 | 108 | check(null, fs.watchFile, fileUrl2, common.fail); | |
| 109 | - check(fs.writeFile, fs.writeFileSync, fileUrl2); | ||
| 109 | + check(fs.writeFile, fs.writeFileSync, fileUrl2, 'abc'); | ||
| 110 | 110 | ||
| 111 | 111 | // an 'error' for exists means that it doesn't exist. | |
| 112 | 112 | // one of many reasons why this file is the absolute worst. | |
0 commit comments