tools: fix `require-common-first` lint rule from subfolder · nodejs/node@a4f336f · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a4f336f

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

committed

tools: fix require-common-first lint rule from subfolder

PR-URL: #56325 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>

1 parent 0ec2ed0 commit a4f336f
Copy full SHA for a4f336f

3 files changed

+7-2Lines changed: 7 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test
  • addons/esm
    • test-esm.mjs
  • parallel
    • test-eslint-require-common-first.js
• tools/eslint-rules
  • require-common-first.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/addons/esm/test-esm.mjs‎

Copy file name to clipboardExpand all lines: test/addons/esm/test-esm.mjs

-1Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -4,7 +4,6 @@
4	4	* the ESM loader or the CJS loader.
5	5	*/
6	6
7		- // eslint-disable-next-line node-core/require-common-first
8	7	import { buildType } from '../../common/index.mjs';
9	8	import assert from 'node:assert';
10	9	import { createRequire } from 'node:module';

Collapse file

‎test/parallel/test-eslint-require-common-first.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-eslint-require-common-first.js

+6Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -20,6 +20,12 @@ new RuleTester({
20	20	code: 'require("common")\n' +
21	21	'require("assert")'
22	22	},
	23	+ {
	24	+ code: 'import "../../../../common/index.mjs";',
	25	+ languageOptions: {
	26	+ sourceType: 'module',
	27	+ },
	28	+ },
23	29	],
24	30	invalid: [
25	31	{

Collapse file

‎tools/eslint-rules/require-common-first.js‎

Copy file name to clipboardExpand all lines: tools/eslint-rules/require-common-first.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -22,7 +22,7 @@ module.exports = {
22	22	* @returns {string} module name
23	23	*/
24	24	function getModuleName(str) {
25		- if (str === '../common/index.mjs') {
	25	+ if (str.startsWith('../') && str.endsWith('/common/index.mjs')) {
26	26	return 'common';
27	27	}
28	28

0 commit comments

Comments

0 (0)