test_runner: don't await the same promise for each test · nodejs/node@a501860 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a501860

Browse filesBrowse the repository at this point in the historyBrowse files

cjihrig

authored and

marco-ippolito

committed

test_runner: don't await the same promise for each test

Prior to this commit, each top level test awaited the same global promise for setting up test reporters. This commit updates the logic to only await the promise the first time it is encountered. PR-URL: #52185 Refs: #47164 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

1 parent 053282e commit a501860
Copy full SHA for a501860

1 file changed

+5-1Lines changed: 5 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/test_runner
  • harness.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/test_runner/harness.js‎

Copy file name to clipboardExpand all lines: lib/internal/test_runner/harness.js

+5-1Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -233,7 +233,11 @@ function getGlobalRoot() {
233	233	}
234	234
235	235	async function startSubtest(subtest) {
236		- await reportersSetup;
	236	+ if (reportersSetup) {
	237	+ // Only incur the overhead of awaiting the Promise once.
	238	+ await reportersSetup;
	239	+ reportersSetup = undefined;
	240	+ }
237	241
238	242	const root = getGlobalRoot();
239	243	if (!root.harness.bootstrapComplete) {

0 commit comments

Comments

0 (0)