Commit a522c0e
src: use MaybeLocal.ToLocal instead of IsEmpty
This commit suggest using MaybeLocal.ToLocal and passing in the
Local<Function> fun.
The motivation for doing this is that the following
MaybeLocal.ToLocalChecked call can then be avoided.
PR-URL: #33457
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>1 parent 5fb1cc8 commit a522c0e
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -284,14 +284,14 @@ MaybeLocal<Function> NativeModuleLoader::LookupAndCompile( | |||
| 284 | 284 | ||
| 285 | 285 | // This could fail when there are early errors in the native modules, | |
| 286 | 286 | // e.g. the syntax errors | |
| 287 | - if (maybe_fun.IsEmpty()) { | ||
| 287 | + Local<Function> fun; | ||
| 288 | + if (!maybe_fun.ToLocal(&fun)) { | ||
| 288 | 289 | // In the case of early errors, v8 is already capable of | |
| 289 | 290 | // decorating the stack for us - note that we use CompileFunctionInContext | |
| 290 | 291 | // so there is no need to worry about wrappers. | |
| 291 | 292 | return MaybeLocal<Function>(); | |
| 292 | 293 | } | |
| 293 | 294 | ||
| 294 | - Local<Function> fun = maybe_fun.ToLocalChecked(); | ||
| 295 | 295 | // XXX(joyeecheung): this bookkeeping is not exactly accurate because | |
| 296 | 296 | // it only starts after the Environment is created, so the per_context.js | |
| 297 | 297 | // will never be in any of these two sets, but the two sets are only for | |
0 commit comments