Commit a569ae4
test: remove third argument from assert.strictEqual()
In file test/parallel/test-stream-transform-final.js the ten calls to
assert.strictEqual() use a string literal as third argument. When
a AssertionError occurs, it reports the string literal and not the
first two arguments, so the third agrument is removed and made a
comment just above the call to assert.strictEqual().
PR-URL: #22051
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 168abb5 commit a569ae4
1 file changed
Lines changed: 20 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -59,44 +59,54 @@ The order things are called | |||
| 59 | 59 | const t = new stream.Transform({ | |
| 60 | 60 | objectMode: true, | |
| 61 | 61 | transform: common.mustCall(function(chunk, _, next) { | |
| 62 | - assert.strictEqual(++state, chunk, 'transformCallback part 1'); | ||
| 62 | + // transformCallback part 1 | ||
| 63 | + assert.strictEqual(++state, chunk); | ||
| 63 | 64 | this.push(state); | |
| 64 | - assert.strictEqual(++state, chunk + 2, 'transformCallback part 2'); | ||
| 65 | + // transformCallback part 2 | ||
| 66 | + assert.strictEqual(++state, chunk + 2); | ||
| 65 | 67 | process.nextTick(next); | |
| 66 | 68 | }, 3), | |
| 67 | 69 | final: common.mustCall(function(done) { | |
| 68 | 70 | state++; | |
| 69 | - assert.strictEqual(state, 10, 'finalCallback part 1'); | ||
| 71 | + // finalCallback part 1 | ||
| 72 | + assert.strictEqual(state, 10); | ||
| 70 | 73 | setTimeout(function() { | |
| 71 | 74 | state++; | |
| 72 | - assert.strictEqual(state, 11, 'finalCallback part 2'); | ||
| 75 | + // finalCallback part 2 | ||
| 76 | + assert.strictEqual(state, 11); | ||
| 73 | 77 | done(); | |
| 74 | 78 | }, 100); | |
| 75 | 79 | }, 1), | |
| 76 | 80 | flush: common.mustCall(function(done) { | |
| 77 | 81 | state++; | |
| 78 | - assert.strictEqual(state, 12, 'flushCallback part 1'); | ||
| 82 | + // flushCallback part 1 | ||
| 83 | + assert.strictEqual(state, 12); | ||
| 79 | 84 | process.nextTick(function() { | |
| 80 | 85 | state++; | |
| 81 | - assert.strictEqual(state, 15, 'flushCallback part 2'); | ||
| 86 | + // flushCallback part 2 | ||
| 87 | + assert.strictEqual(state, 15); | ||
| 82 | 88 | done(); | |
| 83 | 89 | }); | |
| 84 | 90 | }, 1) | |
| 85 | 91 | }); | |
| 86 | 92 | t.on('finish', common.mustCall(function() { | |
| 87 | 93 | state++; | |
| 88 | - assert.strictEqual(state, 13, 'finishListener'); | ||
| 94 | + // finishListener | ||
| 95 | + assert.strictEqual(state, 13); | ||
| 89 | 96 | }, 1)); | |
| 90 | 97 | t.on('end', common.mustCall(function() { | |
| 91 | 98 | state++; | |
| 92 | - assert.strictEqual(state, 16, 'end event'); | ||
| 99 | + // end event | ||
| 100 | + assert.strictEqual(state, 16); | ||
| 93 | 101 | }, 1)); | |
| 94 | 102 | t.on('data', common.mustCall(function(d) { | |
| 95 | - assert.strictEqual(++state, d + 1, 'dataListener'); | ||
| 103 | + // dataListener | ||
| 104 | + assert.strictEqual(++state, d + 1); | ||
| 96 | 105 | }, 3)); | |
| 97 | 106 | t.write(1); | |
| 98 | 107 | t.write(4); | |
| 99 | 108 | t.end(7, common.mustCall(function() { | |
| 100 | 109 | state++; | |
| 101 | - assert.strictEqual(state, 14, 'endMethodCallback'); | ||
| 110 | + // endMethodCallback | ||
| 111 | + assert.strictEqual(state, 14); | ||
| 102 | 112 | }, 1)); | |
0 commit comments