Commit a69d30e
module: drop -u alias for --conditions
Old versions of mocha break after #34637.
This was a bug in mocha, but since this is a widely used module
we can expect ecosystem breakage until modules are updated to
the latest version of mocha. Drop the conflicting `-u` alias --
we can potentially bring it back once modules have been updated.
PR-URL: #34935
Refs: mochajs/mocha#4417
Refs: #34637
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>1 parent cf34854 commit a69d30e
4 files changed
Lines changed: 4 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -76,7 +76,7 @@ $ node --completion-bash > node_bash_completion | |||
| 76 | 76 | $ source node_bash_completion | |
| 77 | 77 | ``` | |
| 78 | 78 | ||
| 79 | - ### `-u`, `--conditions=condition` | ||
| 79 | + ### `--conditions=condition` | ||
| 80 | 80 | <!-- YAML | |
| 81 | 81 | added: REPLACEME | |
| 82 | 82 | --> | |
@@ -1214,7 +1214,7 @@ node --require "./a.js" --require "./b.js" | |||
| 1214 | 1214 | ||
| 1215 | 1215 | Node.js options that are allowed are: | |
| 1216 | 1216 | <!-- node-options-node start --> | |
| 1217 | - * `--conditions`, `-u` | ||
| 1217 | + * `--conditions` | ||
| 1218 | 1218 | * `--diagnostic-dir` | |
| 1219 | 1219 | * `--disable-proto` | |
| 1220 | 1220 | * `--enable-fips` | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -78,7 +78,7 @@ Aborting instead of exiting causes a core file to be generated for analysis. | |||
| 78 | 78 | .It Fl -completion-bash | |
| 79 | 79 | Print source-able bash completion script for Node.js. | |
| 80 | 80 | . | |
| 81 | - .It Fl u , Fl -conditions Ar string | ||
| 81 | + .It Fl -conditions Ar string | ||
| 82 | 82 | Use custom conditional exports conditions | |
| 83 | 83 | .Ar string | |
| 84 | 84 | . | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -285,7 +285,6 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() { | |||
| 285 | 285 | "additional user conditions for conditional exports and imports", | |
| 286 | 286 | &EnvironmentOptions::conditions, | |
| 287 | 287 | kAllowedInEnvironment); | |
| 288 | - AddAlias("-u", "--conditions"); | ||
| 289 | 288 | AddOption("--diagnostic-dir", | |
| 290 | 289 | "set dir for all output files" | |
| 291 | 290 | " (default: current working directory)", | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,4 +1,4 @@ | |||
| 1 | - // Flags: --conditions=custom-condition -u another | ||
| 1 | + // Flags: --conditions=custom-condition --conditions another | ||
| 2 | 2 | import { mustCall } from '../common/index.mjs'; | |
| 3 | 3 | import { strictEqual } from 'assert'; | |
| 4 | 4 | import { requireFixture, importFixture } from '../fixtures/pkgexports.mjs'; | |
0 commit comments