tools: do not use the set-output command in workflows · nodejs/node@a70b276 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a70b276

Browse filesBrowse the repository at this point in the historyBrowse files

lpinca

authored and

RafaelGSS

committed

tools: do not use the set-output command in workflows

The `set-output` command is deprecated. Use the `GITHUB_OUTPUT` environment file. Refs: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ PR-URL: #45024 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent d41f8ff commit a70b276
Copy full SHA for a70b276

4 files changed

+11-9Lines changed: 11 additions & 9 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .github/workflows
  • auto-start-ci.yml
  • commit-lint.yml
  • commit-queue.yml
  • label-flaky-test-issue.yml

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.github/workflows/auto-start-ci.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/auto-start-ci.yml

+4-3Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -28,12 +28,13 @@ jobs:
28	28	- name: Get Pull Requests
29	29	id: get_prs_for_ci
30	30	run: >
31		- gh pr list \
	31	+ numbers=$(gh pr list \
32	32	--repo ${{ github.repository }} \
33	33	--label 'request-ci' \
34	34	--json 'number' \
35		- -t '::set-output name=numbers::{{ range . }}{{ .number }} {{ end }}' \
36		- --limit 100
	35	+ -t '{{ range . }}{{ .number }} {{ end }}' \
	36	+ --limit 100)
	37	+ echo "numbers=$numbers" >> $GITHUB_OUTPUT
37	38	env:
38	39	GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
39	40	start-ci:

Collapse file

‎.github/workflows/commit-lint.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/commit-lint.yml

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -15,8 +15,8 @@ jobs:
15	15	- name: Compute number of commits in the PR
16	16	id: nb-of-commits
17	17	run: |
18		- echo "::set-output name=plusOne::$((${{ github.event.pull_request.commits }} + 1))"
19		- echo "::set-output name=minusOne::$((${{ github.event.pull_request.commits }} - 1))"
	18	+ echo "plusOne=$((${{ github.event.pull_request.commits }} + 1))" >> $GITHUB_OUTPUT
	19	+ echo "minusOne=$((${{ github.event.pull_request.commits }} - 1))" >> $GITHUB_OUTPUT
20	20	- uses: actions/checkout@v3
21	21	with:
22	22	fetch-depth: ${{ steps.nb-of-commits.outputs.plusOne }}

Collapse file

‎.github/workflows/commit-queue.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/commit-queue.yml

+4-3Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -33,13 +33,14 @@ jobs:
33	33	- name: Get Pull Requests
34	34	id: get_mergeable_prs
35	35	run: >
36		- gh pr list \
	36	+ numbers=$(gh pr list \
37	37	--repo ${{ github.repository }} \
38	38	--base ${{ github.ref_name }} \
39	39	--label 'commit-queue' \
40	40	--json 'number' \
41		- -t '::set-output name=numbers::{{ range . }}{{ .number }} {{ end }}' \
42		- --limit 100
	41	+ -t '{{ range . }}{{ .number }} {{ end }}' \
	42	+ --limit 100)
	43	+ echo "numbers=$numbers" >> $GITHUB_OUTPUT
43	44	env:
44	45	GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
45	46	commitQueue:

Collapse file

‎.github/workflows/label-flaky-test-issue.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/label-flaky-test-issue.yml

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -41,7 +41,7 @@ jobs:
41	41	labels="${labels}${platform2label[$platform]},"; \
42	42	done;
43	43
44		- echo "::set-output name=LABELS::${labels::-1}"
	44	+ echo "LABELS=${labels::-1}" >> $GITHUB_OUTPUT
45	45
46	46	- name: Add labels
47	47	env:

0 commit comments

Comments

0 (0)