assert: use a set instead of an array for faster lookup · nodejs/node@a73279c · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a73279c

Browse filesBrowse the repository at this point in the historyBrowse files

BridgeAR

authored and

aduh95

committed

assert: use a set instead of an array for faster lookup

This is a very small improvement for error creation. PR-URL: #61076 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

1 parent cf0eabc commit a73279c
Copy full SHA for a73279c

1 file changed

+7-3Lines changed: 7 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/assert
  • assertion_error.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/assert/assertion_error.js‎

Copy file name to clipboardExpand all lines: lib/internal/assert/assertion_error.js

+7-3Lines changed: 7 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -10,6 +10,7 @@ const {
10	10	ObjectDefineProperty,
11	11	ObjectGetPrototypeOf,
12	12	ObjectPrototypeHasOwnProperty,
	13	+ SafeSet,
13	14	String,
14	15	StringPrototypeRepeat,
15	16	StringPrototypeSlice,
@@ -42,7 +43,10 @@ const kReadableOperator = {
42	43	const kMaxShortStringLength = 12;
43	44	const kMaxLongStringLength = 512;
44	45
45		- const kMethodsWithCustomMessageDiff = ['deepStrictEqual', 'strictEqual', 'partialDeepStrictEqual'];
	46	+ const kMethodsWithCustomMessageDiff = new SafeSet()
	47	+ .add('deepStrictEqual')
	48	+ .add('strictEqual')
	49	+ .add('partialDeepStrictEqual');
46	50
47	51	function copyError(source) {
48	52	const target = ObjectAssign(
@@ -263,7 +267,7 @@ class AssertionError extends Error {
263	267	if (isErrorStackTraceLimitWritable()) Error.stackTraceLimit = 0;
264	268
265	269	if (message != null) {
266		- if (kMethodsWithCustomMessageDiff.includes(operator)) {
	270	+ if (kMethodsWithCustomMessageDiff.has(operator)) {
267	271	super(createErrDiff(actual, expected, operator, message, diff));
268	272	} else {
269	273	super(String(message));
@@ -283,7 +287,7 @@ class AssertionError extends Error {
283	287	expected = copyError(expected);
284	288	}
285	289
286		- if (kMethodsWithCustomMessageDiff.includes(operator)) {
	290	+ if (kMethodsWithCustomMessageDiff.has(operator)) {
287	291	super(createErrDiff(actual, expected, operator, message, diff));
288	292	} else if (operator === 'notDeepStrictEqual' ||
289	293	operator === 'notStrictEqual') {

0 commit comments

Comments

0 (0)