Revert "test: disable MultipleEnvironmentsPerIsolate" · nodejs/node@a781bb4 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 748
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a781bb4

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

committed

Revert "test: disable MultipleEnvironmentsPerIsolate"

This reverts commit 95ab966. Ref: #14206 Ref: #14246 PR-URL: #14749 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

1 parent 8ff2a5c commit a781bb4
Copy full SHA for a781bb4

1 file changed

-2Lines changed: 0 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/cctest
  • test_environment.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/cctest/test_environment.cc‎

Copy file name to clipboardExpand all lines: test/cctest/test_environment.cc

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -85,7 +85,6 @@ TEST_F(EnvironmentTest, AtExitWithArgument) {
85	85	EXPECT_EQ(arg, cb_1_arg);
86	86	}
87	87
88		- /*
89	88	TEST_F(EnvironmentTest, MultipleEnvironmentsPerIsolate) {
90	89	const v8::HandleScope handle_scope(isolate_);
91	90	const Argv argv;
@@ -101,7 +100,6 @@ TEST_F(EnvironmentTest, MultipleEnvironmentsPerIsolate) {
101	100	RunAtExit(*env2);
102	101	EXPECT_TRUE(called_cb_2);
103	102	}
104		- */
105	103
106	104	static void at_exit_callback1(void* arg) {
107	105	called_cb_1 = true;

0 commit comments

Comments

0 (0)