| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
1 parent dc2af26 commit a854bb3
1 file changed
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2387,10 +2387,12 @@ napi_status NAPI_CDECL napi_create_external(napi_env env, | |||
| 2387 | 2387 | ||
| 2388 | 2388 | v8::Local<v8::Value> external_value = v8::External::New(isolate, data); | |
| 2389 | 2389 | ||
| 2390 | - // The Reference object will delete itself after invoking the finalizer | ||
| 2391 | - // callback. | ||
| 2392 | - v8impl::Reference::New( | ||
| 2393 | - env, external_value, 0, true, finalize_cb, data, finalize_hint); | ||
| 2390 | + if (finalize_cb) { | ||
| 2391 | + // The Reference object will delete itself after invoking the finalizer | ||
| 2392 | + // callback. | ||
| 2393 | + v8impl::Reference::New( | ||
| 2394 | + env, external_value, 0, true, finalize_cb, data, finalize_hint); | ||
| 2395 | + } | ||
| 2394 | 2396 | ||
| 2395 | 2397 | *result = v8impl::JsValueFromV8LocalValue(external_value); | |
| 2396 | 2398 | ||
| Back | FazBrowse Home | New Git URL |
0 commit comments