tools,lib: remove `global` and `Intl` from the list of globals · nodejs/node@a87fa5b · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 757
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a87fa5b

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

bengl

committed

tools,lib: remove global and Intl from the list of globals

Refs: #38230 Refs: #38419 PR-URL: #42014 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

1 parent 0461729 commit a87fa5b
Copy full SHA for a87fa5b

2 files changed

+3-5Lines changed: 3 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • .eslintrc.yaml
  • internal/per_context
    • primordials.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/.eslintrc.yaml‎

Copy file name to clipboardExpand all lines: lib/.eslintrc.yaml

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -173,9 +173,7 @@ rules:
173	173	- name: WeakSet
174	174	into: Safe
175	175	globals:
176		- Intl: false
177	176	# Parameters passed to internal modules
178		- global: false
179	177	require: false
180	178	process: false
181	179	exports: false

Collapse file

‎lib/internal/per_context/primordials.js‎

Copy file name to clipboardExpand all lines: lib/internal/per_context/primordials.js

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -162,7 +162,7 @@ function copyPrototype(src, dest, prefix) {
162	162	'Reflect',
163	163	].forEach((name) => {
164	164	// eslint-disable-next-line no-restricted-globals
165		- copyPropsRenamed(global[name], primordials, name);
	165	+ copyPropsRenamed(globalThis[name], primordials, name);
166	166	});
167	167
168	168	// Create copies of intrinsic objects
@@ -206,7 +206,7 @@ function copyPrototype(src, dest, prefix) {
206	206	'WeakSet',
207	207	].forEach((name) => {
208	208	// eslint-disable-next-line no-restricted-globals
209		- const original = global[name];
	209	+ const original = globalThis[name];
210	210	primordials[name] = original;
211	211	copyPropsRenamed(original, primordials, name);
212	212	copyPrototype(original.prototype, primordials, `${name}Prototype`);
@@ -219,7 +219,7 @@ function copyPrototype(src, dest, prefix) {
219	219	'Promise',
220	220	].forEach((name) => {
221	221	// eslint-disable-next-line no-restricted-globals
222		- const original = global[name];
	222	+ const original = globalThis[name];
223	223	primordials[name] = original;
224	224	copyPropsRenamedBound(original, primordials, name);
225	225	copyPrototype(original.prototype, primordials, `${name}Prototype`);

0 commit comments

Comments

0 (0)