Commit a99755f
test: fix typos in read-buffer tests
The offset-exceeding tests for readFloat contained a double test
for readFloatLE instead of one for readFloatLE and one for
readFloatBE. This is fixed in this commit.
PR-URL: #16834
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 1c192f5 commit a99755f
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -59,13 +59,13 @@ read(buf, 'readUIntBE', [2, 0], 0xfd); | |||
| 59 | 59 | read(buf, 'readUIntLE', [2, 0], 0x48); | |
| 60 | 60 | ||
| 61 | 61 | // attempt to overflow buffers, similar to previous bug in array buffers | |
| 62 | - assert.throws(() => Buffer.allocUnsafe(8).readFloatLE(0xffffffff), | ||
| 62 | + assert.throws(() => Buffer.allocUnsafe(8).readFloatBE(0xffffffff), | ||
| 63 | 63 | RangeError); | |
| 64 | 64 | assert.throws(() => Buffer.allocUnsafe(8).readFloatLE(0xffffffff), | |
| 65 | 65 | RangeError); | |
| 66 | 66 | ||
| 67 | 67 | // ensure negative values can't get past offset | |
| 68 | - assert.throws(() => Buffer.allocUnsafe(8).readFloatLE(-1), RangeError); | ||
| 68 | + assert.throws(() => Buffer.allocUnsafe(8).readFloatBE(-1), RangeError); | ||
| 69 | 69 | assert.throws(() => Buffer.allocUnsafe(8).readFloatLE(-1), RangeError); | |
| 70 | 70 | ||
| 71 | 71 | // offset checks | |
0 commit comments