Commit a9a606f
lib: use full URL to GitHub issues in comments
Don't assume the reader of the code will know where to find the issue
tracker. Provide the full URL. This is especially important if the
issue tracker should move again.
PR-URL: #34686
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 68c5ee4 commit a9a606f
1 file changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -204,7 +204,8 @@ function onStreamRead(arrayBuffer) { | |||
| 204 | 204 | } | |
| 205 | 205 | ||
| 206 | 206 | if (nread !== UV_EOF) { | |
| 207 | - // #34375 CallJSOnreadMethod expects the return value to be a buffer. | ||
| 207 | + // CallJSOnreadMethod expects the return value to be a buffer. | ||
| 208 | + // Ref: https://github.com/nodejs/node/pull/34375 | ||
| 208 | 209 | stream.destroy(errnoException(nread, 'read')); | |
| 209 | 210 | return; | |
| 210 | 211 | } | |
@@ -224,7 +225,8 @@ function onStreamRead(arrayBuffer) { | |||
| 224 | 225 | if (handle.readStop) { | |
| 225 | 226 | const err = handle.readStop(); | |
| 226 | 227 | if (err) { | |
| 227 | - // #34375 CallJSOnreadMethod expects the return value to be a buffer. | ||
| 228 | + // CallJSOnreadMethod expects the return value to be a buffer. | ||
| 229 | + // Ref: https://github.com/nodejs/node/pull/34375 | ||
| 228 | 230 | stream.destroy(errnoException(err, 'read')); | |
| 229 | 231 | return; | |
| 230 | 232 | } | |
0 commit comments