Commit a9a93f3
committed
meta: edit collaborator nomination process
- recommend more strongly a private discussion prior to a public one.
- add requirement for the nominee to publicly accept the nomination.
- move recommendation for heads up comment from "How to review
nominations" section to "Nominating new Collaborator" section.
PR-URL: #57483
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>1 parent 5652da6 commit a9a93f3
1 file changed
Lines changed: 28 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -146,8 +146,31 @@ Contributions can be: | |||
| 146 | 146 | ||
| 147 | 147 | ### Nominating a new Collaborator | |
| 148 | 148 | ||
| 149 | - To nominate a new Collaborator, open an issue in the [nodejs/node][] repository. | ||
| 150 | - Provide a summary of the nominee's contributions. For example: | ||
| 149 | + To nominate a new Collaborator: | ||
| 150 | + | ||
| 151 | + 1. **Optional but strongly recommended**: open a | ||
| 152 | + [discussion in the nodejs/collaborators][] repository. Provide a summary of | ||
| 153 | + the nominee's contributions (see below for an example). | ||
| 154 | + 2. **Optional but strongly recommended**: After sufficient wait time (e.g. 72 | ||
| 155 | + hours), if the nomination proposal has received some support and no explicit | ||
| 156 | + block, add a comment in the private discussion stating you're planning on | ||
| 157 | + opening a public issue, e.g. "I see a number of approvals and no block, I'll | ||
| 158 | + be opening a public nomination issue if I don't hear any objections in the | ||
| 159 | + next 72 hours". | ||
| 160 | + 3. **Optional but strongly recommended**: Privately contact the nominee to make | ||
| 161 | + sure they're comfortable with the nomination. | ||
| 162 | + 4. Open an issue in the [nodejs/node][] repository. Provide a summary of | ||
| 163 | + the nominee's contributions (see below for an example). Mention | ||
| 164 | + @nodejs/collaborators in the issue to notify other collaborators about | ||
| 165 | + the nomination. | ||
| 166 | + | ||
| 167 | + The _Optional but strongly recommended_ steps are optional in the sense that | ||
| 168 | + skipping them would not invalidate the nomination, but it could put the nominee | ||
| 169 | + in a very awkward situation if a nomination they didn't ask for pops out of | ||
| 170 | + nowhere only to be rejected. Do not skip those steps unless you're absolutely | ||
| 171 | + certain the nominee is fine with the public scrutiny. | ||
| 172 | + | ||
| 173 | + Example of list of contributions: | ||
| 151 | 174 | ||
| 152 | 175 | * Commits in the [nodejs/node][] repository. | |
| 153 | 176 | * Use the link `https://github.com/nodejs/node/commits?author=GITHUB_ID` | |
@@ -166,19 +189,11 @@ Provide a summary of the nominee's contributions. For example: | |||
| 166 | 189 | organization | |
| 167 | 190 | * Other participation in the wider Node.js community | |
| 168 | 191 | ||
| 169 | - Mention @nodejs/collaborators in the issue to notify other collaborators about | ||
| 170 | - the nomination. | ||
| 171 | - | ||
| 172 | - The nomination passes if no collaborators oppose it after one week. In the case | ||
| 192 | + The nomination passes if no collaborators oppose it after one week, and if the | ||
| 193 | + nominee publicly accepts it. In the case | ||
| 173 | 194 | of an objection, the TSC is responsible for working with the individuals | |
| 174 | 195 | involved and finding a resolution. | |
| 175 | 196 | ||
| 176 | - There are steps a nominator can take in advance to make a nomination as | ||
| 177 | - frictionless as possible. To request feedback from other collaborators in | ||
| 178 | - private, use the [collaborators discussion page][] | ||
| 179 | - (which only collaborators may view). A nominator may also work with the | ||
| 180 | - nominee to improve their contribution profile. | ||
| 181 | - | ||
| 182 | 197 | Collaborators might overlook someone with valuable contributions. In that case, | |
| 183 | 198 | the contributor may open an issue or contact a collaborator to request a | |
| 184 | 199 | nomination. | |
@@ -206,11 +221,6 @@ push commits, etc.), so what's the minimal amount is subjective, and there will | |||
| 206 | 221 | be cases where collaborators disagree on whether a nomination should move | |
| 207 | 222 | forward. | |
| 208 | 223 | ||
| 209 | - When concerns have been raised on the private discussion, refrain from opening | ||
| 210 | - the public issue. If no one has explicitly blocked the nomination and you'd like | ||
| 211 | - it to move forward, comment something like "If I don't hear any objections | ||
| 212 | - before (some time), I will open the public issue". | ||
| 213 | - | ||
| 214 | 224 | ### Onboarding | |
| 215 | 225 | ||
| 216 | 226 | After the nomination passes, a TSC member onboards the new collaborator. See | |
@@ -224,6 +234,6 @@ The TSC follows a [Consensus Seeking][] decision-making model per the | |||
| 224 | 234 | ||
| 225 | 235 | [Consensus Seeking]: https://en.wikipedia.org/wiki/Consensus-seeking_decision-making | |
| 226 | 236 | [TSC Charter]: https://github.com/nodejs/TSC/blob/HEAD/TSC-Charter.md | |
| 227 | - [collaborators discussion page]: https://github.com/nodejs/collaborators/discussions/categories/collaborator-nominations | ||
| 237 | + [discussion in the nodejs/collaborators]: https://github.com/nodejs/collaborators/discussions/categories/collaborator-nominations | ||
| 228 | 238 | [nodejs/help]: https://github.com/nodejs/help | |
| 229 | 239 | [nodejs/node]: https://github.com/nodejs/node | |
0 commit comments