build: ensure v8_pointer_compression_sandbox is enabled on 64bit · nodejs/node@a9c04ea · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 749
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a9c04ea

Browse filesBrowse the repository at this point in the historyBrowse files

codebytere

authored and

marco-ippolito

committed

build: ensure v8_pointer_compression_sandbox is enabled on 64bit

PR-URL: #53884 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

1 parent 6bafe8a commit a9c04ea
Copy full SHA for a9c04ea

2 files changed

+2Lines changed: 2 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• common.gypi
• configure.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -115,6 +115,7 @@
115	115	['target_arch in "arm ia32 mips mipsel ppc"', {
116	116	'v8_enable_pointer_compression': 0,
117	117	'v8_enable_31bit_smis_on_64bit_arch': 0,
	118	+ 'v8_enable_sandbox': 0
118	119	}],
119	120	['target_arch in "ppc64 s390x"', {
120	121	'v8_enable_backtrace': 1,

Collapse file

‎configure.py‎

Copy file name to clipboardExpand all lines: configure.py

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1572,6 +1572,7 @@ def configure_v8(o):
1572	1572	o['variables']['v8_use_siphash'] = 0 if options.without_siphash else 1
1573	1573	o['variables']['v8_enable_maglev'] = 1 if options.v8_enable_maglev else 0
1574	1574	o['variables']['v8_enable_pointer_compression'] = 1 if options.enable_pointer_compression else 0
	1575	+ o['variables']['v8_enable_sandbox'] = 1 if options.enable_pointer_compression else 0
1575	1576	o['variables']['v8_enable_31bit_smis_on_64bit_arch'] = 1 if options.enable_pointer_compression else 0
1576	1577	o['variables']['v8_enable_shared_ro_heap'] = 0 if options.enable_pointer_compression or options.disable_shared_ro_heap else 1
1577	1578	o['variables']['v8_enable_extensible_ro_snapshot'] = 0

0 commit comments

Comments

0 (0)