Commit a9c0689
committed
crypto: fix return type prob reported by coverity
Coverity correctly reported that the value returned
by BIO_get_mem_data could be negative and the type
provided for the return value was unsigned.
Fix up the type and check.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #42135
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>1 parent 3ba4124 commit a9c0689
1 file changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -741,9 +741,10 @@ static bool PrintGeneralName(const BIOPointer& out, const GENERAL_NAME* gen) { | |||
| 741 | 741 | return false; | |
| 742 | 742 | } | |
| 743 | 743 | char* oline = nullptr; | |
| 744 | - size_t n_bytes = BIO_get_mem_data(tmp.get(), &oline); | ||
| 744 | + long n_bytes = BIO_get_mem_data(tmp.get(), &oline); // NOLINT(runtime/int) | ||
| 745 | + CHECK_GE(n_bytes, 0); | ||
| 745 | 746 | CHECK_IMPLIES(n_bytes != 0, oline != nullptr); | |
| 746 | - PrintAltName(out, oline, n_bytes, true, nullptr); | ||
| 747 | + PrintAltName(out, oline, static_cast<size_t>(n_bytes), true, nullptr); | ||
| 747 | 748 | } else if (gen->type == GEN_IPADD) { | |
| 748 | 749 | BIO_printf(out.get(), "IP Address:"); | |
| 749 | 750 | const ASN1_OCTET_STRING* ip = gen->d.ip; | |
0 commit comments