Commit a9dbb22
util: fix width detection for DEL without ICU
This makes sure the DEL character (ASCII 127) is detected as a zero
width character even if Node.js is not built with ICU.
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #33650
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent 02ae3f5 commit a9dbb22
2 files changed
Lines changed: 2 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2047,7 +2047,7 @@ if (internalBinding('config').hasIntl) { | |||
| 2047 | 2047 | ||
| 2048 | 2048 | const isZeroWidthCodePoint = (code) => { | |
| 2049 | 2049 | return code <= 0x1F || // C0 control codes | |
| 2050 | - (code > 0x7F && code <= 0x9F) || // C1 control codes | ||
| 2050 | + (code >= 0x7F && code <= 0x9F) || // C1 control codes | ||
| 2051 | 2051 | (code >= 0x300 && code <= 0x36F) || // Combining Diacritical Marks | |
| 2052 | 2052 | (code >= 0x200B && code <= 0x200F) || // Modifying Invisible Characters | |
| 2053 | 2053 | // Combining Diacritical Marks for Symbols | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2,9 +2,6 @@ | |||
| 2 | 2 | 'use strict'; | |
| 3 | 3 | const common = require('../common'); | |
| 4 | 4 | ||
| 5 | - if (!common.hasIntl) | ||
| 6 | - common.skip('missing Intl'); | ||
| 7 | - | ||
| 8 | 5 | const assert = require('assert'); | |
| 9 | 6 | const { getStringWidth } = require('internal/util/inspect'); | |
| 10 | 7 | ||
@@ -88,7 +85,7 @@ for (let i = 0; i < 256; i++) { | |||
| 88 | 85 | } | |
| 89 | 86 | } | |
| 90 | 87 | ||
| 91 | - { | ||
| 88 | + if (common.hasIntl) { | ||
| 92 | 89 | const a = '한글'.normalize('NFD'); // 한글 | |
| 93 | 90 | const b = '한글'.normalize('NFC'); // 한글 | |
| 94 | 91 | assert.strictEqual(a.length, 6); | |
0 commit comments