Commit aa05c8b
trace_events: avoid flusing uninitialized traces
PR-URL: #22812
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>1 parent 967fbeb commit aa05c8b
1 file changed
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -59,7 +59,13 @@ void InternalTraceBuffer::Flush(bool blocking) { | |||
| 59 | 59 | for (size_t i = 0; i < total_chunks_; ++i) { | |
| 60 | 60 | auto& chunk = chunks_[i]; | |
| 61 | 61 | for (size_t j = 0; j < chunk->size(); ++j) { | |
| 62 | - agent_->AppendTraceEvent(chunk->GetEventAt(j)); | ||
| 62 | + TraceObject* trace_event = chunk->GetEventAt(j); | ||
| 63 | + // Another thread may have added a trace that is yet to be | ||
| 64 | + // initialized. Skip such traces. | ||
| 65 | + // https://github.com/nodejs/node/issues/21038. | ||
| 66 | + if (trace_event->name()) { | ||
| 67 | + agent_->AppendTraceEvent(trace_event); | ||
| 68 | + } | ||
| 63 | 69 | } | |
| 64 | 70 | } | |
| 65 | 71 | total_chunks_ = 0; | |
0 commit comments