Commit aa4b028
test: improve test-fs-open-flags
* use arrow funcion instead of function expression
* add second argument to method assert.throws
* check error messages from beginning to the end using ^ and $
PR-URL: #10908
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 35d6659 commit aa4b028
1 file changed
Lines changed: 11 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -34,20 +34,27 @@ assert.equal(stringToFlags('xa+'), O_APPEND | O_CREAT | O_RDWR | O_EXCL); | |||
| 34 | 34 | ('+ +a +r +w rw wa war raw r++ a++ w++ x +x x+ rx rx+ wxx wax xwx xxx') | |
| 35 | 35 | .split(' ') | |
| 36 | 36 | .forEach(function(flags) { | |
| 37 | - assert.throws(function() { stringToFlags(flags); }); | ||
| 37 | + assert.throws( | ||
| 38 | + () => stringToFlags(flags), | ||
| 39 | + new RegExp(`^Error: Unknown file open flag: ${escapeRegExp(flags)}`) | ||
| 40 | + ); | ||
| 38 | 41 | }); | |
| 39 | 42 | ||
| 40 | 43 | assert.throws( | |
| 41 | 44 | () => stringToFlags({}), | |
| 42 | - /Unknown file open flag: \[object Object\]/ | ||
| 45 | + /^Error: Unknown file open flag: \[object Object\]$/ | ||
| 43 | 46 | ); | |
| 44 | 47 | ||
| 45 | 48 | assert.throws( | |
| 46 | 49 | () => stringToFlags(true), | |
| 47 | - /Unknown file open flag: true/ | ||
| 50 | + /^Error: Unknown file open flag: true$/ | ||
| 48 | 51 | ); | |
| 49 | 52 | ||
| 50 | 53 | assert.throws( | |
| 51 | 54 | () => stringToFlags(null), | |
| 52 | - /Unknown file open flag: null/ | ||
| 55 | + /^Error: Unknown file open flag: null$/ | ||
| 53 | 56 | ); | |
| 57 | + | ||
| 58 | + function escapeRegExp(string) { | ||
| 59 | + return string.replace(/[\\^$*+?.()|[\]{}]/g, '\\$&'); | ||
| 60 | + } | ||
0 commit comments