Commit aa80826
src: fix ssize_t error from nghttp2.h
The "node_http2.h" include reordering enforced by clang-format broke
Electron's Node.js upgrade on Windows. ssize_t is a part of the POSIX
standard and it's not available on Windows, so the fix for this is to
include "node.h" which typedefs it on Windows in
https://github.com/nodejs/node/blob/bb4dff783ddb3b20c67041f7ccef796c335c2407/src/node.h#L212-L220.
Refs: electron/electron#35350 (comment)
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #44393
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 6b8ed27 commit aa80826
1 file changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3,8 +3,9 @@ | |||
| 3 | 3 | ||
| 4 | 4 | #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS | |
| 5 | 5 | ||
| 6 | - // FIXME(joyeecheung): nghttp2.h needs stdint.h to compile on Windows | ||
| 7 | - #include <cstdint> | ||
| 6 | + // clang-format off | ||
| 7 | + #include "node.h" // nghttp2.h needs ssize_t | ||
| 8 | + // clang-format on | ||
| 8 | 9 | #include "nghttp2/nghttp2.h" | |
| 9 | 10 | ||
| 10 | 11 | #include "env.h" | |
0 commit comments