Commit aaef29e
doc: update release steps when post-release fails
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #63131
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>1 parent e369886 commit aaef29e
1 file changed
Lines changed: 23 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1090,15 +1090,27 @@ There is an automatic build that is kicked off when you promote new builds, so | |||
| 1090 | 1090 | within a few minutes nodejs.org will be listing your new version as the latest | |
| 1091 | 1091 | release, and a blog post draft PR will be created. | |
| 1092 | 1092 | ||
| 1093 | - In the event that a draft PR _is not created_, the [`scripts:release-post`][] script | ||
| 1094 | - can be used as an alternative: | ||
| 1095 | - | ||
| 1096 | - ```bash | ||
| 1097 | - # In the apps/site folder of nodejs/nodejs.org | ||
| 1098 | - node --run scripts:release-post x.y.z | ||
| 1099 | - ``` | ||
| 1100 | - | ||
| 1101 | - This script will use the promoted builds and changelog to generate the post. | ||
| 1093 | + This is driven by the [`post-release.yml`][] workflow in the `nodejs/node` | ||
| 1094 | + repository, which triggers the [`create-release-post.yml`][] workflow on | ||
| 1095 | + `nodejs/nodejs.org`. The same workflow also triggers a redirect update in the | ||
| 1096 | + [`nodejs/release-cloudflare-worker`](https://github.com/nodejs/release-cloudflare-worker) | ||
| 1097 | + repository. Both steps must complete for the release to be fully available on | ||
| 1098 | + the website. | ||
| 1099 | + | ||
| 1100 | + In the event that [`post-release.yml`][] fails, the **first step should be to | ||
| 1101 | + re-run the failed action** rather than manually triggering workflows in other | ||
| 1102 | + repositories. Skipping steps in the process can result in the blog post being | ||
| 1103 | + published without the release documents being available, or without the | ||
| 1104 | + Cloudflare redirects being updated. | ||
| 1105 | + | ||
| 1106 | + If the failed action continues to fail after re-running, you can manually | ||
| 1107 | + trigger both of the following: | ||
| 1108 | + | ||
| 1109 | + 1. The [`create-release-post.yml`][] workflow on the `nodejs/nodejs.org` | ||
| 1110 | + repository. | ||
| 1111 | + 2. The release worker update on the | ||
| 1112 | + [`nodejs/release-cloudflare-worker`](https://github.com/nodejs/release-cloudflare-worker) | ||
| 1113 | + repository. | ||
| 1102 | 1114 | ||
| 1103 | 1115 | * You can add a short blurb just under the main heading if you want to say | |
| 1104 | 1116 | something important, otherwise the text should be publication ready. | |
@@ -1485,8 +1497,9 @@ Typical resolution: sign the release again. | |||
| 1485 | 1497 | [CI lockdown procedure]: https://github.com/nodejs/build/blob/HEAD/doc/jenkins-guide.md#restricting-access-for-security-releases | |
| 1486 | 1498 | [Node.js Snap management repository]: https://github.com/nodejs/snap | |
| 1487 | 1499 | [Snap]: https://snapcraft.io/node | |
| 1500 | + [`create-release-post.yml`]: https://github.com/nodejs/nodejs.org/actions/workflows/create-release-post.yml | ||
| 1488 | 1501 | [`create-release-proposal`]: https://github.com/nodejs/node/actions/workflows/create-release-proposal.yml | |
| 1489 | - [`scripts:release-post`]: https://github.com/nodejs/nodejs.org/blob/HEAD/apps/site/scripts/release-post/index.mjs | ||
| 1502 | + [`post-release.yml`]: https://github.com/nodejs/node/actions/workflows/post-release.yml | ||
| 1490 | 1503 | [build-infra team]: https://github.com/orgs/nodejs/teams/build-infra | |
| 1491 | 1504 | [expected assets]: https://github.com/nodejs/build/tree/HEAD/ansible/www-standalone/tools/promote/expected_assets | |
| 1492 | 1505 | [nodejs.org repository]: https://github.com/nodejs/nodejs.org | |
0 commit comments