| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
1 parent 292aa42 commit ab0da57
1 file changed
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -67,7 +67,7 @@ For first-time contributors, check if the commit author is the same as the | |||
| 67 | 67 | pull request author, and ask if they have configured their git | |
| 68 | 68 | username and email to their liking as per [this guide][git-username]. | |
| 69 | 69 | This is to make sure they would be promoted to "contributor" once | |
| 70 | - their pull request gets landed. | ||
| 70 | + their pull request lands. | ||
| 71 | 71 | ||
| 72 | 72 | ### Closing Issues and Pull Requests | |
| 73 | 73 | ||
@@ -82,32 +82,31 @@ necessary. | |||
| 82 | 82 | ### Author ready pull requests | |
| 83 | 83 | ||
| 84 | 84 | A pull request that is still awaiting the minimum review time is considered | |
| 85 | - `author-ready` as soon as the CI has been started, it has at least one approval, | ||
| 85 | + _author ready_ as soon as the CI has been started, it has at least one approval, | ||
| 86 | 86 | and it has no outstanding review comments. Please always make sure to add the | |
| 87 | - appropriate `author-ready` label to the PR in that case and remove it again as | ||
| 88 | - soon as that condition is not met anymore. | ||
| 87 | + `author ready` label to the PR in that case and remove it again as soon as that | ||
| 88 | + condition is not met anymore. | ||
| 89 | 89 | ||
| 90 | 90 | ### Handling own pull requests | |
| 91 | 91 | ||
| 92 | - If you as a Collaborator open a pull request, it is recommended to start a CI | ||
| 93 | - right after (see [testing and CI](#testing-and-ci) for further information on | ||
| 94 | - how to do that) and to post the link to it as well. Starting a new CI after each | ||
| 95 | - update is also recommended (due to e.g., a change request in a review or due to | ||
| 96 | - rebasing). | ||
| 92 | + When you open a pull request, it is recommended to start a CI right away (see | ||
| 93 | + [testing and CI](#testing-and-ci) for instructions) and to post the link to it | ||
| 94 | + in a comment in the pull request. Starting a new CI after each update is also | ||
| 95 | + recommended (for example, after an additional code change or after rebasing). | ||
| 97 | 96 | ||
| 98 | - As soon as the PR is ready to land, please go ahead and do so on your own. | ||
| 99 | - Landing your own pull requests distributes the work load for each Collaborator | ||
| 100 | - equally. If it is still awaiting the | ||
| 101 | - [minimum time to land](#waiting-for-approvals), please add the `author-ready` | ||
| 102 | - label to it so it is obvious that the PR can land as soon as the time ends. | ||
| 97 | + As soon as the PR is ready to land, please do so. Landing your own pull requests | ||
| 98 | + allows other Collaborators to focus on other pull requests. If your pull request | ||
| 99 | + is still awaiting the [minimum time to land](#waiting-for-approvals), add the | ||
| 100 | + `author ready` label so other Collaborators know it can land as soon as the time | ||
| 101 | + ends. | ||
| 103 | 102 | ||
| 104 | 103 | ## Accepting Modifications | |
| 105 | 104 | ||
| 106 | 105 | All modifications to the Node.js code and documentation should be performed via | |
| 107 | 106 | GitHub pull requests, including modifications by Collaborators and TSC members. | |
| 108 | 107 | A pull request must be reviewed, and must also be tested with CI, before being | |
| 109 | - landed into the codebase. There may be exception to the latter (the changed code | ||
| 110 | - can not be tested with a CI or similar). If that is the case, please leave a | ||
| 108 | + landed into the codebase. There may be exceptions to the latter (the changed | ||
| 109 | + code cannot be tested with a CI or similar). If that is the case, please leave a | ||
| 111 | 110 | comment that explains why the PR does not require a CI run. | |
| 112 | 111 | ||
| 113 | 112 | ### Code Reviews | |
@@ -140,7 +139,7 @@ the CI outcome. | |||
| 140 | 139 | If there is no disagreement amongst Collaborators, a pull request should be | |
| 141 | 140 | landed given appropriate review, a green CI, and the minimum | |
| 142 | 141 | [waiting time](#waiting-for-approvals) for a PR. If it is still awaiting the | |
| 143 | - [minimum time to land](#waiting-for-approvals), please add the `author-ready` | ||
| 142 | + [minimum time to land](#waiting-for-approvals), please add the `author ready` | ||
| 144 | 143 | label to it so it is obvious that the PR can land as soon as the time ends. | |
| 145 | 144 | ||
| 146 | 145 | Where there is discussion amongst Collaborators, consensus should be sought if | |
| Back | FazBrowse Home | New Git URL |
0 commit comments