test: print stack immediately avoiding GC interleaving · nodejs/node@adce20c · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit adce20c

Browse filesBrowse the repository at this point in the historyBrowse files

legendecas

authored and

aduh95

committed

test: print stack immediately avoiding GC interleaving

`require(mod)` does not keep the mod in require cache if mod throws synchronously. This fixes the tests to print the stack immediately in case that source map cache could be cleaned up when the CJS module is reclaimed by GC in the next event loop tick. PR-URL: #61699 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent c1c6641 commit adce20c
Copy full SHA for adce20c

3 files changed

+6-6Lines changed: 6 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/source_map
  • source_map_cache_map.js
• test/fixtures/source-map/output
  • source_map_sourcemapping_url_string.js
  • source_map_throw_catch.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/source_map/source_map_cache_map.js‎

Copy file name to clipboardExpand all lines: lib/internal/source_map/source_map_cache_map.js

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -13,6 +13,9 @@ const {
13	13	source_map_data_private_symbol,
14	14	},
15	15	} = internalBinding('util');
	16	+ let debug = require('internal/util/debuglog').debuglog('source_map', (fn) => {
	17	+ debug = fn;
	18	+ });
16	19
17	20	/**
18	21	* Specialized map of WeakRefs to module instances that caches source map
@@ -46,6 +49,7 @@ class SourceMapCacheMap {
46	49	ArrayPrototypeForEach(keys, (key) => {
47	50	const ref = this.#weakModuleMap.get(key);
48	51	if (ref && ref.deref() === undefined) {
	52	+ debug(`Cleanup obsolete source map cache entry with key: ${key}`);
49	53	this.#weakModuleMap.delete(key);
50	54	}
51	55	});

Collapse file

‎test/fixtures/source-map/output/source_map_sourcemapping_url_string.js‎

Copy file name to clipboardExpand all lines: test/fixtures/source-map/output/source_map_sourcemapping_url_string.js

+1-3Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -7,7 +7,5 @@ Error.stackTraceLimit = 2;
7	7	try {
8	8	require('../typescript-sourcemapping_url_string');
9	9	} catch (err) {
10		- setTimeout(() => {
11		- console.info(err);
12		- }, 10);
	10	+ console.info(err);
13	11	}

Collapse file

‎test/fixtures/source-map/output/source_map_throw_catch.js‎

Copy file name to clipboardExpand all lines: test/fixtures/source-map/output/source_map_throw_catch.js

+1-3Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -7,7 +7,5 @@ Error.stackTraceLimit = 2;
7	7	try {
8	8	require('../typescript-throw');
9	9	} catch (err) {
10		- setTimeout(() => {
11		- console.info(err);
12		- }, 10);
	10	+ console.info(err);
13	11	}

0 commit comments

Comments

0 (0)