module: refactor NativeModule to avoid unsafe array iteration · nodejs/node@ae0e76c · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit ae0e76c

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

danielleadams

committed

module: refactor NativeModule to avoid unsafe array iteration

PR-URL: #37656 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

1 parent a2d08d5 commit ae0e76c
Copy full SHA for ae0e76c

1 file changed

+4-1Lines changed: 4 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/bootstrap
  • loaders.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/bootstrap/loaders.js‎

Copy file name to clipboardExpand all lines: lib/internal/bootstrap/loaders.js

+4-1Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -46,6 +46,7 @@
46	46	const {
47	47	ArrayPrototypeMap,
48	48	ArrayPrototypePush,
	49	+ ArrayPrototypeSlice,
49	50	Error,
50	51	ObjectCreate,
51	52	ObjectDefineProperty,
@@ -239,8 +240,10 @@ class NativeModule {
239	240	const { ModuleWrap } = internalBinding('module_wrap');
240	241	const url = `node:${this.id}`;
241	242	const nativeModule = this;
	243	+ const exportsKeys = ArrayPrototypeSlice(this.exportKeys);
	244	+ ArrayPrototypePush(exportsKeys, 'default');
242	245	this.module = new ModuleWrap(
243		- url, undefined, [...this.exportKeys, 'default'],
	246	+ url, undefined, exportsKeys,
244	247	function() {
245	248	nativeModule.syncExports();
246	249	this.setExport('default', nativeModule.exports);

0 commit comments

Comments

0 (0)