Commit ae3398a
tools: fix eslint isRequired
Currently the call can lead to a TypeError with the message:
`Cannot read property 'value' of undefined`.
This fixes it by first checking that the first argument is truthy.
PR-URL: #18729
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>1 parent 8e39c3b commit ae3398a
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -8,7 +8,7 @@ | |||
| 8 | 8 | * require calls. | |
| 9 | 9 | */ | |
| 10 | 10 | module.exports.isRequired = function(node, modules) { | |
| 11 | - return node.callee.name === 'require' && | ||
| 11 | + return node.callee.name === 'require' && node.arguments.length !== 0 && | ||
| 12 | 12 | modules.includes(node.arguments[0].value); | |
| 13 | 13 | }; | |
| 14 | 14 | ||
0 commit comments