Commit ae800da
committed
src: disallow JS execution during exit()
This is just an extra safeguard – no JS should run once we’ve
decided that we are going to shutdown the process, but we’re opening
a handle scope in order to access V8, so make sure that our operations
do not lead to JS accidentally being run.
PR-URL: #35020
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>1 parent 3e91519 commit ae800da
1 file changed
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -950,6 +950,8 @@ uv_key_t Environment::thread_local_env = {}; | |||
| 950 | 950 | void Environment::Exit(int exit_code) { | |
| 951 | 951 | if (options()->trace_exit) { | |
| 952 | 952 | HandleScope handle_scope(isolate()); | |
| 953 | + Isolate::DisallowJavascriptExecutionScope disallow_js( | ||
| 954 | + isolate(), Isolate::DisallowJavascriptExecutionScope::CRASH_ON_FAILURE); | ||
| 953 | 955 | ||
| 954 | 956 | if (is_main_thread()) { | |
| 955 | 957 | fprintf(stderr, "(node:%d) ", uv_os_getpid()); | |
0 commit comments