| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
1 parent 92a3dc3 commit aeb539a
2 files changed
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -323,6 +323,12 @@ OutgoingMessage.prototype.uncork = function uncork() { | |||
| 323 | 323 | ||
| 324 | 324 | this[kChunkedBuffer].length = 0; | |
| 325 | 325 | this[kChunkedLength] = 0; | |
| 326 | + | ||
| 327 | + // If we had a pending drain and flushed all data, emit the drain event. | ||
| 328 | + if (this[kNeedDrain] && this.writableLength === 0) { | ||
| 329 | + this[kNeedDrain] = false; | ||
| 330 | + this.emit('drain'); | ||
| 331 | + } | ||
| 326 | 332 | }; | |
| 327 | 333 | ||
| 328 | 334 | OutgoingMessage.prototype.setTimeout = function setTimeout(msecs, callback) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,64 @@ | |||
| 1 | + 'use strict'; | ||
| 2 | + const common = require('../common'); | ||
| 3 | + const http = require('http'); | ||
| 4 | + const assert = require('assert'); | ||
| 5 | + | ||
| 6 | + // Test that drain event is emitted correctly when using cork/uncork | ||
| 7 | + // with ServerResponse and the write buffer is full | ||
| 8 | + | ||
| 9 | + const server = http.createServer(common.mustCall(async (req, res) => { | ||
| 10 | + res.cork(); | ||
| 11 | + | ||
| 12 | + // Write small amount - won't need drain | ||
| 13 | + assert.strictEqual(res.write('1'.repeat(10)), true); | ||
| 14 | + | ||
| 15 | + // Write enough to exceed highWaterMark (set in 'connection' listener) | ||
| 16 | + assert.strictEqual(res.write('2'.repeat(1000)), false); | ||
| 17 | + | ||
| 18 | + // Verify writableNeedDrain is set | ||
| 19 | + assert.strictEqual(res.writableNeedDrain, true); | ||
| 20 | + | ||
| 21 | + // Wait for drain event after uncorking | ||
| 22 | + const drainPromise = new Promise((resolve) => { | ||
| 23 | + res.once('drain', common.mustCall(() => { | ||
| 24 | + // After drain, writableNeedDrain should be false | ||
| 25 | + assert.strictEqual(res.writableNeedDrain, false); | ||
| 26 | + resolve(); | ||
| 27 | + })); | ||
| 28 | + }); | ||
| 29 | + | ||
| 30 | + // Uncork should trigger drain | ||
| 31 | + res.uncork(); | ||
| 32 | + await drainPromise; | ||
| 33 | + | ||
| 34 | + res.end(); | ||
| 35 | + })); | ||
| 36 | + | ||
| 37 | + server.on('connection', common.mustCall((socket) => { | ||
| 38 | + // Set high water mark large enough to cover HTTP overhead + first | ||
| 39 | + // small content batch, but not enough to cover second batch. | ||
| 40 | + socket._writableState.highWaterMark = 1000; | ||
| 41 | + })); | ||
| 42 | + | ||
| 43 | + server.listen(0, common.localhostIPv4, common.mustCall(() => { | ||
| 44 | + http.get({ | ||
| 45 | + host: common.localhostIPv4, | ||
| 46 | + port: server.address().port, | ||
| 47 | + }, common.mustCall((res) => { | ||
| 48 | + let data = ''; | ||
| 49 | + res.setEncoding('utf8'); | ||
| 50 | + | ||
| 51 | + res.on('data', (chunk) => { | ||
| 52 | + data += chunk; | ||
| 53 | + }); | ||
| 54 | + | ||
| 55 | + res.on('end', common.mustCall(() => { | ||
| 56 | + // Verify we got all the data | ||
| 57 | + assert.strictEqual(data.length, 10 + 1000); | ||
| 58 | + assert.strictEqual(data.substring(0, 10), '1'.repeat(10)); | ||
| 59 | + assert.strictEqual(data.substring(10), '2'.repeat(1000)); | ||
| 60 | + | ||
| 61 | + server.close(common.mustCall()); | ||
| 62 | + })); | ||
| 63 | + })); | ||
| 64 | + })); | ||
| Back | FazBrowse Home | New Git URL |
0 commit comments