Commit af24376
build: Intl: deps: bump ICU to 56.1 (GA)
* ICU 56 was just released yesterday. Update to it.
* Notable changes: Unicode 8, CLDR 28, 2-3x number format perf,
20% improvement in Collator startup
* more at http://site.icu-project.org/download/56 or in #2917
Also:
* cleanup out/**/*.d and deps/icu on "make clean"
* cleanup deps/icu on "vcbuild clean"
When building from an non-clean directory, it's important to
run `make clean` or `vcbuild clean` to remove the existing
ICU 55 from the deps path before building.
Fixes: #2917
PR-URL: #3281
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 7c85557 commit af24376
3 files changed
Lines changed: 9 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -67,8 +67,9 @@ uninstall: | |||
| 67 | 67 | ||
| 68 | 68 | clean: | |
| 69 | 69 | -rm -rf out/Makefile $(NODE_EXE) $(NODE_G_EXE) out/$(BUILDTYPE)/$(NODE_EXE) | |
| 70 | - @if [ -d out ]; then find out/ -name '*.o' -o -name '*.a' | xargs rm -rf; fi | ||
| 70 | + @if [ -d out ]; then find out/ -name '*.o' -o -name '*.a' -o -name '*.d' | xargs rm -rf; fi | ||
| 71 | 71 | -rm -rf node_modules | |
| 72 | + @if [ -d deps/icu ]; then echo deleting deps/icu; rm -rf deps/icu; fi | ||
| 72 | 73 | -rm -f test.tap | |
| 73 | 74 | ||
| 74 | 75 | distclean: | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -843,9 +843,8 @@ def glob_to_var(dir_base, dir_sub, patch_dir): | |||
| 843 | 843 | def configure_intl(o): | |
| 844 | 844 | icus = [ | |
| 845 | 845 | { | |
| 846 | - 'url': 'http://download.icu-project.org/files/icu4c/55.1/icu4c-55_1-src.zip', | ||
| 847 | - # from https://ssl.icu-project.org/files/icu4c/55.1/icu4c-src-55_1.md5: | ||
| 848 | - 'md5': '4cddf1e1d47622fdd9de2cd7bb5001fd', | ||
| 846 | + 'url': 'https://ssl.icu-project.org/files/icu4c/56.1/icu4c-56_1-src.zip', | ||
| 847 | + 'md5': '61d71888f14bf00cc3e8a6f2c087d367', | ||
| 849 | 848 | }, | |
| 850 | 849 | ] | |
| 851 | 850 | def icu_download(path): | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -99,6 +99,11 @@ if "%i18n_arg%"=="full-icu" set i18n_arg=--with-intl=full-icu | |||
| 99 | 99 | if "%i18n_arg%"=="small-icu" set i18n_arg=--with-intl=small-icu | |
| 100 | 100 | if "%i18n_arg%"=="intl-none" set i18n_arg=--with-intl=none | |
| 101 | 101 | ||
| 102 | + if not exist "%~dp0deps\icu" goto no-depsicu | ||
| 103 | + if "%target%"=="Clean" echo deleting %~dp0deps\icu | ||
| 104 | + if "%target%"=="Clean" rmdir /S /Q %~dp0deps\icu | ||
| 105 | + :no-depsicu | ||
| 106 | + | ||
| 102 | 107 | call :getnodeversion || exit /b 1 | |
| 103 | 108 | ||
| 104 | 109 | @rem Set environment for msbuild | |
0 commit comments