test: handle null stdio streams in spawnSyncAndAssert helper · nodejs/node@af52410 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit af52410

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

aduh95

committed

test: handle null stdio streams in spawnSyncAndAssert helper

When a test uses 'pipe' for the stdio but the child process crashes, the stream will be null. In this case, don't try to stringify it and instead log an empty string. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #64273 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

1 parent 0ea079b commit af52410
Copy full SHA for af52410

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/common
  • child_process.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/common/child_process.js‎

Copy file name to clipboardExpand all lines: test/common/child_process.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -80,9 +80,9 @@ function expectSyncExit(caller, spawnArgs, {
80	80	function logAndThrow() {
81	81	const tag = `[process ${child.pid}]:`;
82	82	console.error(`${tag} --- stderr ---`);
83		- console.error(stderrStr === undefined ? child.stderr.toString() : stderrStr);
	83	+ console.error(stderrStr === undefined ? (child.stderr?.toString() ?? '') : stderrStr);
84	84	console.error(`${tag} --- stdout ---`);
85		- console.error(stdoutStr === undefined ? child.stdout.toString() : stdoutStr);
	85	+ console.error(stdoutStr === undefined ? (child.stdout?.toString() ?? '') : stdoutStr);
86	86	console.error(`${tag} status = ${child.status}, signal = ${child.signal}`);
87	87
88	88	const error = new Error(`${failures.join('\n')}`);

0 commit comments

Comments

0 (0)