permission: resolve reference to absolute path only for fs permission · nodejs/node@af86625 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit af86625

Browse filesBrowse the repository at this point in the historyBrowse files

daeyeon

authored and

targos

committed

permission: resolve reference to absolute path only for fs permission

For other candidate permissions, such as "net" or "env", this patch will pass the reference without resolving it to an absolute path. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #47930 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

1 parent 0c06bfd commit af86625
Copy full SHA for af86625

1 file changed

+5-2Lines changed: 5 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/process
  • permission.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/process/permission.js‎

Copy file name to clipboardExpand all lines: lib/internal/process/permission.js

+5-2Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -2,6 +2,7 @@
2	2
3	3	const {
4	4	ObjectFreeze,
	5	+ StringPrototypeStartsWith,
5	6	} = primordials;
6	7
7	8	const permission = internalBinding('permission');
@@ -24,8 +25,10 @@ module.exports = ObjectFreeze({
24	25	if (reference != null) {
25	26	// TODO: add support for WHATWG URLs and Uint8Arrays.
26	27	validateString(reference, 'reference');
27		- if (!isAbsolute(reference)) {
28		- return permission.has(scope, resolve(reference));
	28	+ if (StringPrototypeStartsWith(scope, 'fs')) {
	29	+ if (!isAbsolute(reference)) {
	30	+ reference = resolve(reference);
	31	+ }
29	32	}
30	33	}
31	34

0 commit comments

Comments

0 (0)