Commit afd8c1e
buffer: allow invalid encoding in from
Looks like a bug to me but the change should probably
done in a semver majpr.
PR-URL: #54533
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>1 parent fe56949 commit afd8c1e
2 files changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -476,7 +476,7 @@ function createFromString(string, ops, length = ops.byteLength(string)) { | |||
| 476 | 476 | ||
| 477 | 477 | function fromString(string, encoding) { | |
| 478 | 478 | let ops; | |
| 479 | - if (!encoding || encoding === 'utf8') { | ||
| 479 | + if (!encoding || encoding === 'utf8' || typeof encoding !== 'string') { | ||
| 480 | 480 | ops = encodingOps.utf8; | |
| 481 | 481 | } else { | |
| 482 | 482 | ops = getEncodingOps(encoding); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -139,3 +139,6 @@ throws(() => { | |||
| 139 | 139 | code: 'ERR_OUT_OF_RANGE', | |
| 140 | 140 | }) | |
| 141 | 141 | ); | |
| 142 | + | ||
| 143 | + // Invalid encoding is allowed | ||
| 144 | + Buffer.from('asd', 1); | ||
0 commit comments