Commit b00c087
deps: V8: cherry-pick e74d0f437fcd
Original commit message:
[api] add v8::Isolate::GetDefaultLocale()
This allows embedders to query the default locale used by Intl
APIs.
This information is already available to user land via
Intl?.Collator().resolvedOptions().locale, the issue with this
is that it's a lot slower and requires dynamic access to Intl
API, which is subject to patching and prototype pollution so it's
not as reliable for embedders than having a V8 API to query
the default locale directly.
Refs: #54279
Change-Id: I5a1823993c9ae79f8f61f54c6464daf882a09ba3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5772938
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Cr-Commit-Position: refs/heads/main@{#95678}
Refs: v8/v8@e74d0f4
PR-URL: #54279
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent c10aff6 commit b00c087
3 files changed
Lines changed: 19 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.18', | ||
| 39 | + 'v8_embedder_string': '-node.19', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -9,6 +9,7 @@ | |||
| 9 | 9 | #include <stdint.h> | |
| 10 | 10 | ||
| 11 | 11 | #include <memory> | |
| 12 | + #include <string> | ||
| 12 | 13 | #include <utility> | |
| 13 | 14 | ||
| 14 | 15 | #include "cppgc/common.h" | |
@@ -1711,6 +1712,12 @@ class V8_EXPORT Isolate { | |||
| 1711 | 1712 | */ | |
| 1712 | 1713 | void LocaleConfigurationChangeNotification(); | |
| 1713 | 1714 | ||
| 1715 | + /** | ||
| 1716 | + * Returns the default locale in a string if Intl support is enabled. | ||
| 1717 | + * Otherwise returns an empty string. | ||
| 1718 | + */ | ||
| 1719 | + std::string GetDefaultLocale(); | ||
| 1720 | + | ||
| 1714 | 1721 | Isolate() = delete; | |
| 1715 | 1722 | ~Isolate() = delete; | |
| 1716 | 1723 | Isolate(const Isolate&) = delete; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -10577,6 +10577,17 @@ void v8::Isolate::LocaleConfigurationChangeNotification() { | |||
| 10577 | 10577 | #endif // V8_INTL_SUPPORT | |
| 10578 | 10578 | } | |
| 10579 | 10579 | ||
| 10580 | + std::string Isolate::GetDefaultLocale() { | ||
| 10581 | + i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(this); | ||
| 10582 | + ENTER_V8_NO_SCRIPT_NO_EXCEPTION(i_isolate); | ||
| 10583 | + | ||
| 10584 | + #ifdef V8_INTL_SUPPORT | ||
| 10585 | + return i_isolate->DefaultLocale(); | ||
| 10586 | + #else | ||
| 10587 | + return std::string(); | ||
| 10588 | + #endif | ||
| 10589 | + } | ||
| 10590 | + | ||
| 10580 | 10591 | #if defined(V8_OS_WIN) && defined(V8_ENABLE_ETW_STACK_WALKING) | |
| 10581 | 10592 | void Isolate::SetFilterETWSessionByURLCallback( | |
| 10582 | 10593 | FilterETWSessionByURLCallback callback) { | |
0 commit comments