Commit b015747
doc: esm loader example with module.builtinModules
PR-URL: #17385
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>1 parent 8c21430 commit b015747
1 file changed
Lines changed: 3 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -147,15 +147,13 @@ be written: | |||
| 147 | 147 | import url from 'url'; | |
| 148 | 148 | import path from 'path'; | |
| 149 | 149 | import process from 'process'; | |
| 150 | + import Module from 'module'; | ||
| 150 | 151 | ||
| 151 | - const builtins = new Set( | ||
| 152 | - Object.keys(process.binding('natives')).filter((str) => | ||
| 153 | - /^(?!(?:internal|node|v8)\/)/.test(str)) | ||
| 154 | - ); | ||
| 152 | + const builtins = Module.builtinModules; | ||
| 155 | 153 | const JS_EXTENSIONS = new Set(['.js', '.mjs']); | |
| 156 | 154 | ||
| 157 | 155 | export function resolve(specifier, parentModuleURL/*, defaultResolve */) { | |
| 158 | - if (builtins.has(specifier)) { | ||
| 156 | + if (builtins.includes(specifier)) { | ||
| 159 | 157 | return { | |
| 160 | 158 | url: specifier, | |
| 161 | 159 | format: 'builtin' | |
0 commit comments