Commit b044256
build: use LC_ALL of C for maximum compatibility
LC_ALL=en_US breaks on some systems (notably the SmartOS 16
configuration in our CI). Use LC_ALL=C instead.
PR-URL: #21222
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 4e742e3 commit b044256
1 file changed
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -672,10 +672,7 @@ def get_xcode_version(cc): | |||
| 672 | 672 | def get_gas_version(cc): | |
| 673 | 673 | try: | |
| 674 | 674 | custom_env = os.environ.copy() | |
| 675 | - # smartos (a.k.a. sunos5) does not have the en_US locale, and will give: | ||
| 676 | - # `setlocale: LC_ALL: cannot change locale (en_US): Invalid argument` | ||
| 677 | - if 'sunos' not in sys.platform: | ||
| 678 | - custom_env["LC_ALL"] = "en_US" | ||
| 675 | + custom_env["LC_ALL"] = "C" | ||
| 679 | 676 | proc = subprocess.Popen(shlex.split(cc) + ['-Wa,-v', '-c', '-o', | |
| 680 | 677 | '/dev/null', '-x', | |
| 681 | 678 | 'assembler', '/dev/null'], | |
0 commit comments