test: replace deprecated regex test assertions in http trailers test · nodejs/node@b08cb56 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit b08cb56

Browse filesBrowse the repository at this point in the historyBrowse files

cruzz77

authored and

RafaelGSS

committed

test: replace deprecated regex test assertions in http trailers test

PR-URL: #60831 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 2567709 commit b08cb56
Copy full SHA for b08cb56

1 file changed

+6-4Lines changed: 6 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-http-set-trailers.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-http-set-trailers.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-set-trailers.js

+6-4Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -43,8 +43,9 @@ function testHttp10(port, callback) {
43	43
44	44	c.on('end', common.mustCall(() => {
45	45	c.end();
46		- assert.ok(
47		- !/x-foo/.test(res_buffer),
	46	+ assert.doesNotMatch(
	47	+ res_buffer,
	48	+ /x-foo/,
48	49	`No trailer in HTTP/1.0 response. Response buffer: ${res_buffer}`
49	50	);
50	51	callback();
@@ -68,8 +69,9 @@ function testHttp11(port, callback) {
68	69	res_buffer += chunk;
69	70	if (/0\r\n/.test(res_buffer)) { // got the end.
70	71	clearTimeout(tid);
71		- assert.ok(
72		- /0\r\nx-foo: bar\r\n\r\n$/.test(res_buffer),
	72	+ assert.match(
	73	+ res_buffer,
	74	+ /0\r\nx-foo: bar\r\n\r\n$/,
73	75	`No trailer in HTTP/1.1 response. Response buffer: ${res_buffer}`
74	76	);
75	77	callback();

0 commit comments

Comments

0 (0)