test: use `mustSucceed` instead of `mustCall` with `assert.ifError` · nodejs/node@b0e3e69 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit b0e3e69

Browse filesBrowse the repository at this point in the historyBrowse files

fossamagna

authored and

danielleadams

committed

test: use mustSucceed instead of mustCall with assert.ifError

PR-URL: #44196 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

1 parent 3359c2c commit b0e3e69
Copy full SHA for b0e3e69

1 file changed

+6-9Lines changed: 6 additions & 9 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/sequential
  • test-inspector-open.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/sequential/test-inspector-open.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-inspector-open.js

+6-9Lines changed: 6 additions & 9 deletions

Original file line number	Diff line number	Diff line change
@@ -32,25 +32,23 @@ let firstPort;
32	32	function firstOpen(msg) {
33	33	assert.strictEqual(msg.cmd, 'url');
34	34	const port = url.parse(msg.url).port;
35		- ping(port, (err) => {
36		- assert.ifError(err);
	35	+ ping(port, common.mustSucceed(() => {
37	36	// Inspector is already open, and won't be reopened, so args don't matter.
38	37	child.send({ cmd: 'open', args: [kOpenWhileOpen] });
39	38	child.once('message', common.mustCall(tryToOpenWhenOpen));
40	39	firstPort = port;
41		- });
	40	+ }));
42	41	}
43	42
44	43	function tryToOpenWhenOpen(msg) {
45	44	assert.strictEqual(msg.cmd, 'url');
46	45	const port = url.parse(msg.url).port;
47	46	// Reopen didn't do anything, the port was already open, and has not changed.
48	47	assert.strictEqual(port, firstPort);
49		- ping(port, (err) => {
50		- assert.ifError(err);
	48	+ ping(port, common.mustSucceed(() => {
51	49	child.send({ cmd: 'close' });
52	50	child.once('message', common.mustCall(closeWhenOpen));
53		- });
	51	+ }));
54	52	}
55	53
56	54	function closeWhenOpen(msg) {
@@ -73,10 +71,9 @@ function tryToCloseWhenClosed(msg) {
73	71	function reopenAfterClose(msg) {
74	72	assert.strictEqual(msg.cmd, 'url');
75	73	const port = url.parse(msg.url).port;
76		- ping(port, (err) => {
77		- assert.ifError(err);
	74	+ ping(port, common.mustSucceed(() => {
78	75	process.exit();
79		- });
	76	+ }));
80	77	}
81	78
82	79	function ping(port, callback) {

0 commit comments

Comments

0 (0)