test: improve error reporting in test-child-process-pipe-dataflow · nodejs/node@b0ed1e7 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit b0ed1e7

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

danielleadams

committed

test: improve error reporting in test-child-process-pipe-dataflow

When the test fails, it usually ends up failing on the assertion that `wc` did not find as many bytes as it expected. That may not be helpful if it is caused by a failure earlier in the command pipeline ( cat | grep | wc ). Move the byte check to `process.on('exit')` so that other error handlers that report the existence of errors run first. Refs: #25988 PR-URL: #37632 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

1 parent 6192315 commit b0ed1e7
Copy full SHA for b0ed1e7

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-child-process-pipe-dataflow.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-child-process-pipe-dataflow.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-child-process-pipe-dataflow.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -66,8 +66,8 @@ const MB = KB * KB;
66	66	wcBuf += data;
67	67	}));
68	68
69		- wc.on('close', common.mustCall(() => {
	69	+ process.on('exit', () => {
70	70	// Grep always adds one extra byte at the end.
71	71	assert.strictEqual(wcBuf.trim(), (MB + 1).toString());
72		- }));
	72	+ });
73	73	}

0 commit comments

Comments

0 (0)