test: prevent V8 from writing into the system's tmpdir · nodejs/node@b0ed8db · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 753
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit b0ed8db

Browse filesBrowse the repository at this point in the historyBrowse files

targos

authored and

RafaelGSS

committed

test: prevent V8 from writing into the system's tmpdir

Refs: nodejs/build#3864 PR-URL: #54395 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

1 parent 0cf78aa commit b0ed8db
Copy full SHA for b0ed8db

1 file changed

+6-1Lines changed: 6 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-cli-node-options.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-cli-node-options.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-cli-node-options.js

+6-1Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -93,7 +93,12 @@ function expectNoWorker(opt, want, command, wantsError) {
93	93	function expect(
94	94	opt, want, command = 'console.log("B")', wantsError = false, testWorker = true
95	95	) {
96		- const argv = ['-e', command];
	96	+ const argv = [
	97	+ // --perf-basic-prof and --perf-basic-prof-only-functions write to /tmp by default.
	98	+ `--perf-basic-prof-path=${tmpdir.path}`,
	99	+ '-e',
	100	+ command,
	101	+ ];
97	102	const opts = {
98	103	cwd: tmpdir.path,
99	104	env: Object.assign({}, process.env, { NODE_OPTIONS: opt }),

0 commit comments

Comments

0 (0)