Commit b17163b
src: allow embedder customization of OOMErrorHandler
PR-URL: #57325
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>1 parent 17d4074 commit b17163b
2 files changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -233,7 +233,10 @@ void SetIsolateErrorHandlers(v8::Isolate* isolate, const IsolateSettings& s) { | |||
| 233 | 233 | auto* fatal_error_cb = s.fatal_error_callback ? | |
| 234 | 234 | s.fatal_error_callback : OnFatalError; | |
| 235 | 235 | isolate->SetFatalErrorHandler(fatal_error_cb); | |
| 236 | - isolate->SetOOMErrorHandler(OOMErrorHandler); | ||
| 236 | + | ||
| 237 | + auto* oom_error_cb = | ||
| 238 | + s.oom_error_callback ? s.oom_error_callback : OOMErrorHandler; | ||
| 239 | + isolate->SetOOMErrorHandler(oom_error_cb); | ||
| 237 | 240 | ||
| 238 | 241 | if ((s.flags & SHOULD_NOT_SET_PREPARE_STACK_TRACE_CALLBACK) == 0) { | |
| 239 | 242 | auto* prepare_stack_trace_cb = s.prepare_stack_trace_callback ? | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -483,6 +483,7 @@ struct IsolateSettings { | |||
| 483 | 483 | v8::Isolate::AbortOnUncaughtExceptionCallback | |
| 484 | 484 | should_abort_on_uncaught_exception_callback = nullptr; | |
| 485 | 485 | v8::FatalErrorCallback fatal_error_callback = nullptr; | |
| 486 | + v8::OOMErrorCallback oom_error_callback = nullptr; | ||
| 486 | 487 | v8::PrepareStackTraceCallback prepare_stack_trace_callback = nullptr; | |
| 487 | 488 | ||
| 488 | 489 | // Miscellaneous callbacks | |
0 commit comments