Commit b2936cf
src: organize imports in inspector_profiler.cc
In the other .cc files in the project, includes are in alphabetical
order, with local files first, and libraries after. However,
inspector_profiler.cc has a library declared in the middle of the import
order, and v8 is the second to last being imported, instead of the last.
So I reordered the imports and testing showed no side effects;
everything passed.
PR-URL: #29073
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>1 parent 13a4979 commit b2936cf
1 file changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,13 +1,14 @@ | |||
| 1 | 1 | #include "inspector_profiler.h" | |
| 2 | - #include <sstream> | ||
| 3 | 2 | #include "base_object-inl.h" | |
| 4 | 3 | #include "debug_utils.h" | |
| 5 | 4 | #include "diagnosticfilename-inl.h" | |
| 6 | 5 | #include "memory_tracker-inl.h" | |
| 7 | 6 | #include "node_file.h" | |
| 8 | 7 | #include "node_internals.h" | |
| 9 | - #include "v8-inspector.h" | ||
| 10 | 8 | #include "util-inl.h" | |
| 9 | + #include "v8-inspector.h" | ||
| 10 | + | ||
| 11 | + #include <sstream> | ||
| 11 | 12 | ||
| 12 | 13 | namespace node { | |
| 13 | 14 | namespace profiler { | |
@@ -323,7 +324,7 @@ void EndStartedProfilers(Environment* env) { | |||
| 323 | 324 | std::string GetCwd(Environment* env) { | |
| 324 | 325 | char cwd[PATH_MAX_BYTES]; | |
| 325 | 326 | size_t size = PATH_MAX_BYTES; | |
| 326 | - int err = uv_cwd(cwd, &size); | ||
| 327 | + const int err = uv_cwd(cwd, &size); | ||
| 327 | 328 | ||
| 328 | 329 | if (err == 0) { | |
| 329 | 330 | CHECK_GT(size, 0); | |
0 commit comments