console: create the global console from Console constructor · nodejs/node@b2b0645 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit b2b0645

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

BridgeAR

committed

console: create the global console from Console constructor

Specifically for v11.x. PR-URL: #25420 Refs: #23509 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>

1 parent 73c3a3d commit b2b0645
Copy full SHA for b2b0645

1 file changed

+2-1Lines changed: 2 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • console.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/console.js‎

Copy file name to clipboardExpand all lines: lib/console.js

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -487,7 +487,8 @@ function noop() {}
487	487	// we cannot actually use `new Console` to construct the global console.
488	488	// Therefore, the console.Console.prototype is not
489	489	// in the global console prototype chain anymore.
490		- const globalConsole = Object.create({});
	490	+ // This is only here for v11.x conflict resolution.
	491	+ const globalConsole = Object.create(Console.prototype);
491	492	const tempConsole = new Console({
492	493	stdout: process.stdout,
493	494	stderr: process.stderr

0 commit comments

Comments

0 (0)