Commit b2fc3b5
doc: fix n-api example string
- using a length of 6 for `"hello"` includes a terminating null yielding
`"hello\u0000"`
- length of 5 would work,
but comparing to the N-API docs gives `NAPI_AUTO_LENGTH` instead
PR-URL: #19205
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>1 parent d79e7d6 commit b2fc3b5
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -246,7 +246,7 @@ napi_value Method(napi_env env, napi_callback_info args) { | |||
| 246 | 246 | napi_value greeting; | |
| 247 | 247 | napi_status status; | |
| 248 | 248 | ||
| 249 | - status = napi_create_string_utf8(env, "hello", 6, &greeting); | ||
| 249 | + status = napi_create_string_utf8(env, "hello", NAPI_AUTO_LENGTH, &greeting); | ||
| 250 | 250 | if (status != napi_ok) return nullptr; | |
| 251 | 251 | return greeting; | |
| 252 | 252 | } | |
0 commit comments