Commit b30754a
build: run embedtest using node executable
We should use the node executable to run this test, instead of
counting on embedtest, the binary being tested, as the test runner.
Otherwise bugs can go unnoticed if the embedtest binary itself
does not work correctly.
PR-URL: #49506
Fixes: #49501
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 1fffda5 commit b30754a
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -286,7 +286,7 @@ coverage-report-js: | |||
| 286 | 286 | # Runs the C++ tests using the built `cctest` executable. | |
| 287 | 287 | cctest: all | |
| 288 | 288 | @out/$(BUILDTYPE)/$@ --gtest_filter=$(GTEST_FILTER) | |
| 289 | - @out/$(BUILDTYPE)/embedtest "require('./test/embedding/test-embedding.js')" | ||
| 289 | + $(NODE) ./test/embedding/test-embedding.js | ||
| 290 | 290 | ||
| 291 | 291 | .PHONY: list-gtests | |
| 292 | 292 | list-gtests: | |
@@ -550,7 +550,7 @@ test-ci: | clear-stalled bench-addons-build build-addons build-js-native-api-tes | |||
| 550 | 550 | $(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \ | |
| 551 | 551 | --mode=$(BUILDTYPE_LOWER) --flaky-tests=$(FLAKY_TESTS) \ | |
| 552 | 552 | $(TEST_CI_ARGS) $(CI_JS_SUITES) $(CI_NATIVE_SUITES) $(CI_DOC) | |
| 553 | - out/Release/embedtest 'require("./test/embedding/test-embedding.js")' | ||
| 553 | + $(NODE) ./test/embedding/test-embedding.js | ||
| 554 | 554 | $(info Clean up any leftover processes, error if found.) | |
| 555 | 555 | ps awwx | grep Release/node | grep -v grep | cat | |
| 556 | 556 | @PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \ | |
0 commit comments