Commit b36a898
tools: fix inspector_protocol updater
`.github/workflows/tools.yml` creates a temp file `temp-output` in the
workspace, which fails `git status` clean repo check. Also, the GHA
checks out a new branch after the update script.
Removes these checks in the `roll.py` to fix its run on the GHA.
PR-URL: #60277
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>1 parent 748d4f6 commit b36a898
1 file changed
Lines changed: 0 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -47,13 +47,6 @@ def CheckRepoIsClean(path): | |||
| 47 | 47 | raise Exception('%s is not a clean git repo (run git status)' % path) | |
| 48 | 48 | ||
| 49 | 49 | ||
| 50 | - def CheckRepoIsNotAtMainBranch(path): | ||
| 51 | - os.chdir(path) | ||
| 52 | - stdout = RunCmd(['git', 'rev-parse', '--abbrev-ref', 'HEAD']).strip() | ||
| 53 | - if stdout == 'main': | ||
| 54 | - raise Exception('%s is at main branch - refusing to copy there.' % path) | ||
| 55 | - | ||
| 56 | - | ||
| 57 | 50 | def CheckRepoIsInspectorProtocolCheckout(path): | |
| 58 | 51 | os.chdir(path) | |
| 59 | 52 | revision = RunCmd(['git', 'config', '--get', 'remote.origin.url']).strip() | |
@@ -123,12 +116,7 @@ def main(argv): | |||
| 123 | 116 | downstream = os.path.normpath(os.path.expanduser( | |
| 124 | 117 | args.node_src_downstream)) | |
| 125 | 118 | CheckRepoIsClean(upstream) | |
| 126 | - CheckRepoIsClean(downstream) | ||
| 127 | 119 | CheckRepoIsInspectorProtocolCheckout(upstream) | |
| 128 | - # Check that the destination Git repo isn't at the main branch - it's | ||
| 129 | - # generally a bad idea to check into the main branch, so we catch this | ||
| 130 | - # common pilot error here early. | ||
| 131 | - CheckRepoIsNotAtMainBranch(downstream) | ||
| 132 | 120 | ||
| 133 | 121 | # Read V8's inspector_protocol revision | |
| 134 | 122 | v8_ip_revision = ReadV8IPRevision(downstream) | |
0 commit comments