inspector: coerce key and value to string in webstorage events · nodejs/node@b3bfe35 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 752
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit b3bfe35

Browse filesBrowse the repository at this point in the historyBrowse files

thisalihassan

authored and

aduh95

committed

inspector: coerce key and value to string in webstorage events

Signed-off-by: Ali Hassan <ali-hassan27@outlook.com> PR-URL: #62616 Backport-PR-URL: #63176 Refs: #62145 Refs: #62162 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

1 parent 3dc3fb6 commit b3bfe35
Copy full SHA for b3bfe35

1 file changed

+6Lines changed: 6 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/inspector
  • webstorage.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/inspector/webstorage.js‎

Copy file name to clipboardExpand all lines: lib/internal/inspector/webstorage.js

+6Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -7,6 +7,8 @@ const { getOptionValue } = require('internal/options');
7	7
8	8	class InspectorLocalStorage extends Storage {
9	9	setItem(key, value) {
	10	+ key = `${key}`;
	11	+ value = `${value}`;
10	12	const oldValue = this.getItem(key);
11	13	super.setItem(key, value);
12	14	if (oldValue == null) {
@@ -17,6 +19,7 @@ class InspectorLocalStorage extends Storage {
17	19	}
18	20
19	21	removeItem(key) {
	22	+ key = `${key}`;
20	23	super.removeItem(key);
21	24	itemRemoved(key, true);
22	25	}
@@ -29,6 +32,8 @@ class InspectorLocalStorage extends Storage {
29	32
30	33	const InspectorSessionStorage = class extends Storage {
31	34	setItem(key, value) {
	35	+ key = `${key}`;
	36	+ value = `${value}`;
32	37	const oldValue = this.getItem(key);
33	38	super.setItem(key, value);
34	39	if (oldValue == null) {
@@ -39,6 +44,7 @@ const InspectorSessionStorage = class extends Storage {
39	44	}
40	45
41	46	removeItem(key) {
	47	+ key = `${key}`;
42	48	super.removeItem(key);
43	49	itemRemoved(key, false);
44	50	}

0 commit comments

Comments

0 (0)