Commit b3f2045
build: gyp exclude libm linking on macOS
PR-URL: #56901
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>1 parent e0dd9ae commit b3f2045
2 files changed
Lines changed: 9 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -59,14 +59,15 @@ | |||
| 59 | 59 | 'defines': [ | |
| 60 | 60 | 'OS_MACOSX' | |
| 61 | 61 | ] | |
| 62 | + }, { | ||
| 63 | + 'libraries': [ | ||
| 64 | + '-lm', | ||
| 65 | + ], | ||
| 62 | 66 | }], | |
| 63 | 67 | ], | |
| 64 | 68 | 'direct_dependent_settings': { | |
| 65 | 69 | 'include_dirs': [ 'c/include' ] | |
| 66 | 70 | }, | |
| 67 | - 'libraries': [ | ||
| 68 | - '-lm', | ||
| 69 | - ], | ||
| 70 | 71 | 'sources': [ | |
| 71 | 72 | '<@(brotli_sources)', | |
| 72 | 73 | ] | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -220,7 +220,6 @@ | |||
| 220 | 220 | '<@(uv_sources_posix)', | |
| 221 | 221 | ], | |
| 222 | 222 | 'link_settings': { | |
| 223 | - 'libraries': [ '-lm' ], | ||
| 224 | 223 | 'conditions': [ | |
| 225 | 224 | ['OS=="solaris"', { | |
| 226 | 225 | 'ldflags': [ '-pthreads' ], | |
@@ -231,6 +230,11 @@ | |||
| 231 | 230 | ['OS != "solaris" and OS != "android" and OS != "zos"', { | |
| 232 | 231 | 'ldflags': [ '-pthread' ], | |
| 233 | 232 | }], | |
| 233 | + ['OS!="mac"', { | ||
| 234 | + 'libraries': [ | ||
| 235 | + '-lm' | ||
| 236 | + ], | ||
| 237 | + }], | ||
| 234 | 238 | ], | |
| 235 | 239 | }, | |
| 236 | 240 | 'conditions': [ | |
0 commit comments