Commit b3f3b2e
test: fix cluster-worker-isdead
Check if the worker 'isDead' instead of 'isConnected' as the
'disconnect' event is not guaranteed to be received before the
'exit' event.
Remove the 'net' dependency as it is not used.
PR-URL: #3954
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>1 parent e3a8e8b commit b3f3b2e
1 file changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2,7 +2,6 @@ | |||
| 2 | 2 | require('../common'); | |
| 3 | 3 | var cluster = require('cluster'); | |
| 4 | 4 | var assert = require('assert'); | |
| 5 | - var net = require('net'); | ||
| 6 | 5 | ||
| 7 | 6 | if (cluster.isMaster) { | |
| 8 | 7 | var worker = cluster.fork(); | |
@@ -11,7 +10,7 @@ if (cluster.isMaster) { | |||
| 11 | 10 | 'created.'); | |
| 12 | 11 | ||
| 13 | 12 | worker.on('exit', function() { | |
| 14 | - assert.ok(!worker.isConnected(), | ||
| 13 | + assert.ok(worker.isDead(), | ||
| 15 | 14 | 'After an event has been emitted, ' + | |
| 16 | 15 | 'isDead should return true'); | |
| 17 | 16 | }); | |
0 commit comments