src: keep PipeWrap::Open function consistent with TCPWrap · nodejs/node@b454a76 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 758
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit b454a76

Browse filesBrowse the repository at this point in the historyBrowse files

theanarkh

authored and

juanarbol

committed

src: keep PipeWrap::Open function consistent with TCPWrap

PR-URL: #46064 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

1 parent 5539977 commit b454a76
Copy full SHA for b454a76

1 file changed

+2-3Lines changed: 2 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • pipe_wrap.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/pipe_wrap.cc‎

Copy file name to clipboardExpand all lines: src/pipe_wrap.cc

+2-3Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -217,10 +217,9 @@ void PipeWrap::Open(const FunctionCallbackInfo<Value>& args) {
217	217	if (!args[0]->Int32Value(env->context()).To(&fd)) return;
218	218
219	219	int err = uv_pipe_open(&wrap->handle_, fd);
220		- wrap->set_fd(fd);
	220	+ if (err == 0) wrap->set_fd(fd);
221	221
222		- if (err != 0)
223		- env->ThrowUVException(err, "uv_pipe_open");
	222	+ args.GetReturnValue().Set(err);
224	223	}
225	224
226	225

0 commit comments

Comments

0 (0)