src: register missing stream wrap external references · nodejs/node@b4e074c · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit b4e074c

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

BethGriggs

committed

src: register missing stream wrap external references

PR-URL: #39961 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com>

1 parent a2c1c3e commit b4e074c
Copy full SHA for b4e074c

1 file changed

+4Lines changed: 4 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • stream_wrap.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/stream_wrap.cc‎

Copy file name to clipboardExpand all lines: src/stream_wrap.cc

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -106,6 +106,10 @@ void LibuvStreamWrap::Initialize(Local<Object> target,
106	106	void LibuvStreamWrap::RegisterExternalReferences(
107	107	ExternalReferenceRegistry* registry) {
108	108	registry->Register(IsConstructCallCallback);
	109	+ registry->Register(GetWriteQueueSize);
	110	+ registry->Register(SetBlocking);
	111	+ // TODO(joyee): StreamBase::RegisterExternalReferences() is called somewhere
	112	+ // else but we may want to do it here too and guard it with a static flag.
109	113	}
110	114
111	115	LibuvStreamWrap::LibuvStreamWrap(Environment* env,

0 commit comments

Comments

0 (0)